potiuk commented on code in PR #44492:
URL: https://github.com/apache/airflow/pull/44492#discussion_r1864009483
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -974,8 +974,15 @@ def configure_cluster(
output=None,
)
if return_code == 0:
- get_console().print("\n[warning]NEXT STEP:[/][info] You might now
build your k8s image by:\n")
- get_console().print("\nbreeze k8s build-k8s-image\n")
+ get_console().print(
+ "\n[warning]NEXT STEP:[/][info] You might now build your k8s
image "
+ "with all latest dependencies:\n"
+ )
+ get_console().print("\n breeze k8s build-k8s-image
--rebuild-base-image\n")
Review Comment:
We need - in case dependencies changed (this was likely the reason why it
failed for @ashb today) - and for sure failed for me when I followed it. The
problem is if you build the image in the past, and use it as a base, airflow
might not start. The problem for me was that `asyncpg` was missing in the image
- because we added it last week and latest sources of airflow required it.
I have no good idea for now how to make sure that the prod image is only
rebuilt when needed (it takes time) - so next best thing is to ask the user to
force it when they go through the normal k8s testing process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
