potiuk commented on code in PR #44492:
URL: https://github.com/apache/airflow/pull/44492#discussion_r1864249341
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -974,8 +974,15 @@ def configure_cluster(
output=None,
)
if return_code == 0:
- get_console().print("\n[warning]NEXT STEP:[/][info] You might now
build your k8s image by:\n")
- get_console().print("\nbreeze k8s build-k8s-image\n")
+ get_console().print(
+ "\n[warning]NEXT STEP:[/][info] You might now build your k8s
image "
+ "with all latest dependencies:\n"
+ )
+ get_console().print("\n breeze k8s build-k8s-image
--rebuild-base-image\n")
Review Comment:
Yeah. I will think of a better way of doing it later -> this part is very
"slow" to iterate on and there are more gotchas and inefficiences of the `K8S
tests` experience - which is far from ideal. It's been experienced in the past
by @ephraimbuddy and yesterday by @ashb . While having the tests is super
useful to test the whole stack of ours (`airflow` + `image` + `chart`) - and as
the `LocalExceutor` failure the day before have shown it's great to have them
to catch it early, iterating on them is a pain.
I created an issue in our "CI/CD/DEVENV" project
https://github.com/apache/airflow/issues/44508 describing all the defficiencies
and potential ways we can improve them.
##########
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##########
@@ -974,8 +974,15 @@ def configure_cluster(
output=None,
)
if return_code == 0:
- get_console().print("\n[warning]NEXT STEP:[/][info] You might now
build your k8s image by:\n")
- get_console().print("\nbreeze k8s build-k8s-image\n")
+ get_console().print(
+ "\n[warning]NEXT STEP:[/][info] You might now build your k8s
image "
+ "with all latest dependencies:\n"
+ )
+ get_console().print("\n breeze k8s build-k8s-image
--rebuild-base-image\n")
Review Comment:
Yeah. I will think of a better way of doing it later -> this part is very
"slow" to iterate on and there are more gotchas and inefficiences of the `K8S
tests` experience - which is far from ideal. It's been experienced in the past
by @ephraimbuddy and yesterday by @ashb .
While having the tests is super useful to test the whole stack of ours
(`airflow` + `image` + `chart`) - and as the `LocalExceutor` failure the day
before have shown it's great to have them to catch it early, iterating on them
is a pain.
I created an issue in our "CI/CD/DEVENV" project
https://github.com/apache/airflow/issues/44508 describing all the defficiencies
and potential ways we can improve them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
