dstandish commented on code in PR #44456:
URL: https://github.com/apache/airflow/pull/44456#discussion_r1876201562
##########
airflow/dag_processing/collection.py:
##########
@@ -435,14 +456,17 @@ def add_asset_trigger_references(
refs_to_add: dict[tuple[str, str], set[str]] = {}
refs_to_remove: dict[tuple[str, str], set[str]] = {}
triggers: dict[str, BaseTrigger] = {}
+ active_assets = _find_active_assets(self.assets.keys(),
session=session)
Review Comment:
just while looking noticed the `unique()`.... `unique()` is... i hate to
use the term... a bit of a code smell... when you see `unique()` you know
there's a good chance that there is some funnybusiness... probably the query
could be rewritten to return the distinct results, and _possibly_ it could be
susceptible to join explosion since you _must_ be returning unwanted rows
otherwise you would not need to call unique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]