dstandish commented on code in PR #44456:
URL: https://github.com/apache/airflow/pull/44456#discussion_r1876209901
##########
airflow/dag_processing/collection.py:
##########
@@ -435,14 +456,17 @@ def add_asset_trigger_references(
refs_to_add: dict[tuple[str, str], set[str]] = {}
refs_to_remove: dict[tuple[str, str], set[str]] = {}
triggers: dict[str, BaseTrigger] = {}
+ active_assets = _find_active_assets(self.assets.keys(),
session=session)
Review Comment:
i think the query looks uglier than it is.
it can be simplified to this
```
select(AssetModel)
.join(
AssetActive,
AssetActive.name == AssetModel.name,
AssetActive.uri == AssetModel.uri,
)
.where(
tuple_(AssetActive.name, AssetActive.uri).in_(name_uri_assets),
AssetModel.consuming_dags.any(DagScheduleAssetReference.dag_id.in_(active_dags)),
)
```
(ignoring the options etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]