jscheffl commented on code in PR #44863:
URL: https://github.com/apache/airflow/pull/44863#discussion_r1881476776
##########
airflow/ui/src/components/DocumentationModal.tsx:
##########
@@ -23,14 +23,21 @@ import Markdown from "react-markdown";
import { Button, Dialog } from "src/components/ui";
-const DagDocumentation = ({ docMd }: { readonly docMd: string }) => {
+const DocumentationModal = ({
+ docMd,
+ isDag = false,
Review Comment:
Instead of making it boolean... atm it is used only in task and dag... would
it make sense to rather pass a `readonly docType: string` as parameter and use
this as `docType` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
