pierrejeambrun commented on code in PR #44863: URL: https://github.com/apache/airflow/pull/44863#discussion_r1882398241
########## airflow/ui/src/components/DocumentationModal.tsx: ########## @@ -23,14 +23,21 @@ import Markdown from "react-markdown"; import { Button, Dialog } from "src/components/ui"; -const DagDocumentation = ({ docMd }: { readonly docMd: string }) => { +const DocumentationModal = ({ + docMd, + isDag = false, Review Comment: No strong opinion on that. (at least we don't have the confusion that `isDag=False` and it's a new entity that doesn't yet exist that is also not a task, more extensible, but really nit I don't mind). Merging like this we can update if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org