jscheffl commented on code in PR #45060:
URL: https://github.com/apache/airflow/pull/45060#discussion_r1890896396
##########
scripts/ci/pre_commit/compile_www_assets.py:
##########
@@ -71,4 +72,23 @@ def get_directory_hash(directory: Path, skip_path_regexp:
str | None = None) ->
subprocess.check_call(["yarn", "install", "--frozen-lockfile"],
cwd=os.fspath(www_directory))
subprocess.check_call(["yarn", "run", "build"],
cwd=os.fspath(www_directory), env=env)
new_hash = get_directory_hash(www_directory,
skip_path_regexp=r".*node_modules.*")
- WWW_HASH_FILE.write_text(new_hash)
+ www_hash_file.write_text(new_hash)
+
+
+def is_fab_provider_installed() -> bool:
+ return (
+ importlib.util.find_spec("airflow") is not None
Review Comment:
I am not sure whether this will work. because airflow and providers are not
installed in pre-commit.
But as you can be sure the source tree is checked-out, how about checking if
source tree is available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
