vincbeck commented on code in PR #45060:
URL: https://github.com/apache/airflow/pull/45060#discussion_r1890902708
##########
scripts/ci/pre_commit/compile_www_assets.py:
##########
@@ -71,4 +72,23 @@ def get_directory_hash(directory: Path, skip_path_regexp:
str | None = None) ->
subprocess.check_call(["yarn", "install", "--frozen-lockfile"],
cwd=os.fspath(www_directory))
subprocess.check_call(["yarn", "run", "build"],
cwd=os.fspath(www_directory), env=env)
new_hash = get_directory_hash(www_directory,
skip_path_regexp=r".*node_modules.*")
- WWW_HASH_FILE.write_text(new_hash)
+ www_hash_file.write_text(new_hash)
+
+
+def is_fab_provider_installed() -> bool:
+ return (
+ importlib.util.find_spec("airflow") is not None
Review Comment:
But when you install, the sources are not available, are not they? So
`is_fab_provider_installed` will return `False` in this case? Although we wan
do want to generate assets for FAB as well. As for the `pre-commit`, since
Airflow is not installed, `is_fab_provider_installed` will return `False`.
I am not 100% sure I understand everything correctly here so I might be
wrong :)
EDIT: what I meant is, it is okay to not generate the assets for FAB in the
CI, however, when Airflow is installed, we definitely should generate them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
