jscheffl commented on code in PR #45220:
URL: https://github.com/apache/airflow/pull/45220#discussion_r1898026696
##########
airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -136,73 +142,74 @@ const TriggerDAGForm: React.FC<TriggerDAGFormProps> = ({
return (
<>
- <ErrorAlert error={errorTrigger} />
- <Accordion.Root collapsible mt={4} size="lg" variant="enclosed">
+ <Accordion.Root collapsible mb={4} mt={4} size="lg" variant="enclosed">
<Accordion.Item key="advancedOptions" value="advancedOptions">
<Accordion.ItemTrigger cursor="button">
Advanced Options
</Accordion.ItemTrigger>
<Accordion.ItemContent>
<Box p={5}>
- <Text fontSize="md" mb={2}>
- Data Interval Start Date
- </Text>
<Controller
control={control}
name="dataIntervalStart"
render={({ field }) => (
- <Input
- {...field}
- max={dataIntervalEnd || undefined}
- onBlur={() => validateDates("dataIntervalStart")}
- placeholder="yyyy-mm-ddThh:mm"
- size="sm"
- type="datetime-local"
- />
+ <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Label fontSize="md">
+ Data Interval Start Date
+ </Field.Label>
+ <Input
+ {...field}
+ max={dataIntervalEnd || undefined}
+ onBlur={() => validateDates("dataIntervalStart")}
+ placeholder="yyyy-mm-ddThh:mm"
Review Comment:
I don't know if this is a limitation of the date/time component but if I
just use the date picker and leave the time as is (==un-filled) then the
component assumes it is "not filled" and the picked date is ignored. Also the
validation does not kick-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
