shubhamraj-git commented on code in PR #45220:
URL: https://github.com/apache/airflow/pull/45220#discussion_r1898036616
##########
airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -136,73 +142,74 @@ const TriggerDAGForm: React.FC<TriggerDAGFormProps> = ({
return (
<>
- <ErrorAlert error={errorTrigger} />
- <Accordion.Root collapsible mt={4} size="lg" variant="enclosed">
+ <Accordion.Root collapsible mb={4} mt={4} size="lg" variant="enclosed">
<Accordion.Item key="advancedOptions" value="advancedOptions">
<Accordion.ItemTrigger cursor="button">
Advanced Options
</Accordion.ItemTrigger>
<Accordion.ItemContent>
<Box p={5}>
- <Text fontSize="md" mb={2}>
- Data Interval Start Date
- </Text>
<Controller
control={control}
name="dataIntervalStart"
render={({ field }) => (
- <Input
- {...field}
- max={dataIntervalEnd || undefined}
- onBlur={() => validateDates("dataIntervalStart")}
- placeholder="yyyy-mm-ddThh:mm"
- size="sm"
- type="datetime-local"
- />
+ <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Label fontSize="md">
+ Data Interval Start Date
+ </Field.Label>
+ <Input
+ {...field}
+ max={dataIntervalEnd || undefined}
+ onBlur={() => validateDates("dataIntervalStart")}
+ placeholder="yyyy-mm-ddThh:mm"
Review Comment:
Is filling the date and not time, manually checks for validation (Fill only
one either start or end)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
