dstandish commented on PR #45537: URL: https://github.com/apache/airflow/pull/45537#issuecomment-2583313628
> I think by having this as two subclasses (for a total of three classes) also means we can keep the public signature as it is taking `ActivitySubprocess.start(dag_path, ti, client=client, logger=logger)`, and that could then pass the right things on to `child_started_kwargs` in the super call etc? The dag processor does not pass a TI -- it only passes (optionally) a callback list. I'll look into whether this can be further improved by having a base class but, i think if nothing else, this PR does not make the situation worse and just makes explicit and clear all the shenanigans that were sorta hidden before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
