ashb commented on code in PR #45537:
URL: https://github.com/apache/airflow/pull/45537#discussion_r1910174656


##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -286,13 +286,13 @@ def exit(n: int) -> NoReturn:
 
 @attrs.define()
 class WatchedSubprocess:
-    id: UUID
+    id: UUID | None
     pid: int
 
     stdin: BinaryIO
     """The handle connected to stdin of the child process"""
 
-    client: Client
+    client: Client | None

Review Comment:
   What broke with leaving this as it was?
   
   I wonder if instead of doing this change it might be better to have three 
classes -- the "base" WatchedSubproces, and then create a new class like:
   
   ```python
   class ActivitySubprocess(WatchedSubprocess):
       id: UUID
       client: Client
   
       def _on_child_started(self, ti: TaskInstance, path: str | 
os.PathLike[str], requests_fd: int):
           ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to