bugraoz93 commented on PR #45715: URL: https://github.com/apache/airflow/pull/45715#issuecomment-2608067378
> Hey @bugraoz93 , we replaced `action_if_exists ` and `action_if_not_exists` with `action_on_existence` > > 1. This contains, "overwrite", which would be not relevant in case of delete and update, and will fail. > 2. Also, `action_on_existence` seems misleading in case of update and delete, since the operations here were for if the value is not present and not on existence, when either it fails or skip. > > Was this intentional? Or just a miss, in case I can rectify this in upcoming PR for bulk pool. Hey @shubhamraj-git , This was the baseline for making things common for the bulk endpoints so implementation is still from surface at the moment. I think things are getting clearer while we implement more use cases/endpoints. On the documentation perspective `overwrite` is not relevant and it could be a side effect/bug since we are allowing to call the endpoints with `overwrite` in this case. I think we can drive from a parent `enum class` to make documentation nice and separate the `enum classes` according to action types. I am planning to do more unification for the datamodels in #45816. I can cover this one over there, it seems relevant. Please bring up anything in that issue to discuss more. Thanks for pointing out! I would be happy to bounce ideas and am going to tag you in the next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
