bugraoz93 commented on PR #45715: URL: https://github.com/apache/airflow/pull/45715#issuecomment-2608090615
>For now, based upon above comments, I have included that in https://github.com/apache/airflow/pull/45939 I just saw this update after sending my message :) Feel free to change that part in your MR, I don't want to block you on that. Thanks! >For now, I have solved the bug by removing the action_on_existence from BaseModel, and included that differently for create and (delete & update). This solves all the three issues. This can be later unified when you are working on https://github.com/apache/airflow/issues/45816 . Let me know if you need to do this in other way. > >Also, I did this since the Pool Bulk PR https://github.com/apache/airflow/pull/45939 is ready, and this seems to be earliest solution, didn't brainstorm more, since you are already working on https://github.com/apache/airflow/issues/45816 which will anyways refactor these all. Amazing, thanks! Looks good! I agree, fixing is enough and no need for brainstorming. I was trying to not put the work on you (mostly updating tests since they are unified now) :) I can move from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org