potiuk commented on code in PR #46405:
URL: https://github.com/apache/airflow/pull/46405#discussion_r1940595968
##########
dev/breeze/src/airflow_breeze/prepare_providers/provider_documentation.py:
##########
@@ -1222,6 +1222,13 @@ def _regenerate_pyproject_toml(context: dict[str, Any],
provider_details: Provid
context["EXTRAS_REQUIREMENTS"] = "\n".join(optional_dependencies)
context["DEPENDENCY_GROUPS"] = "\n".join(dependency_groups)
+ # Most providers require the same python versions, but some may have
exclusions
Review Comment:
That's not the right place to set the context values (that's why the CI
fails) - here we only override the values that we manually modify in
pyproject.toml (dependencies are manually modified directly in pyproject.toml
- so before we regenerate pyproject.toml we read them from there - including
comments - so that they are used when we regenerate pyproject.toml with other
changes.
The right place where to set the context is `get_provider_jinja_context` in
`src/airflow_breeze/utils/packages.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
