dstandish commented on code in PR #46295:
URL: https://github.com/apache/airflow/pull/46295#discussion_r1943375403
##########
airflow/migrations/versions/0032_3_0_0_rename_execution_date_to_logical_date_and_nullable.py:
##########
@@ -61,9 +66,11 @@ def downgrade():
"logical_date",
new_column_name="execution_date",
existing_type=TIMESTAMP(timezone=True),
- existing_nullable=False,
+ nullable=False,
Review Comment:
in the downgrade, we would need to do something about the nulls. either
delete the runs, or move them to an archive table, or populate them with
1900-01-01 or something. @jedcunningham ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
