jedcunningham commented on code in PR #46295:
URL: https://github.com/apache/airflow/pull/46295#discussion_r1943395620
##########
airflow/migrations/versions/0032_3_0_0_rename_execution_date_to_logical_date_and_nullable.py:
##########
@@ -61,9 +66,11 @@ def downgrade():
"logical_date",
new_column_name="execution_date",
existing_type=TIMESTAMP(timezone=True),
- existing_nullable=False,
+ nullable=False,
Review Comment:
hmm, depends how cheeky I'm feeling haha. The downside of populating a old
fake value is the need for it to be unique, seems like a pain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
