shahar1 commented on code in PR #46584:
URL: https://github.com/apache/airflow/pull/46584#discussion_r1947936092


##########
airflow/models/skipmixin.py:
##########
@@ -120,8 +120,13 @@ def skip(
             return

Review Comment:
   If my suggestion for relocating the "skipping" logic to the task_runner 
makes sense, I think that both `SkipMixin` and `BranchMixin` will be eventually 
deleted (you could ignore the changes here, it's from #44925).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to