ashb commented on code in PR #46584:
URL: https://github.com/apache/airflow/pull/46584#discussion_r1948040226
##########
airflow/ti_deps/deps/not_previously_skipped_dep.py:
##########
@@ -49,46 +48,47 @@ def _get_dep_statuses(self, ti, session, dep_context):
finished_task_ids = {t.task_id for t in finished_tis}
for parent in upstream:
- if isinstance(parent, SkipMixin):
Review Comment:
Removing this makes the scheduler have to check this for all operators where
it didn't before.
Given this is in the hottest of hot paths in the scheduler we might need to
rethink this: perhaps we store a flag in the ser dag like we did for `is_empty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
