Lee-W commented on code in PR #46512:
URL: https://github.com/apache/airflow/pull/46512#discussion_r1953781252
##########
airflow/models/dagrun.py:
##########
@@ -253,12 +253,14 @@ def __init__(
dag_version: DagVersion | None = None,
bundle_version: str | None = None,
):
+ # For manual runs where logical_date is None, ensure no data_interval
is set.
+ if logical_date is None and data_interval is not None:
+ raise ValueError("data_interval must be None if logical_date is
None")
+
if data_interval is None:
- # Legacy: Only happen for runs created prior to Airflow 2.2.
- self.data_interval_start = self.data_interval_end = None
+ self.data_interval_start, self.data_interval_end = None, None
Review Comment:
We probably don't really need to change this line. Both are readable for me.
not sure how others think 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
