uranusjr commented on code in PR #46512:
URL: https://github.com/apache/airflow/pull/46512#discussion_r1948438527
##########
airflow/models/dagrun.py:
##########
@@ -621,10 +623,18 @@ def find_duplicate(cls, dag_id: str, run_id: str, *,
session: Session = NEW_SESS
return session.scalars(select(cls).where(cls.dag_id == dag_id,
cls.run_id == run_id)).one_or_none()
@staticmethod
- def generate_run_id(run_type: DagRunType, logical_date: datetime) -> str:
- """Generate Run ID based on Run Type and logical Date."""
+ def generate_run_id(
+ run_type: DagRunType, logical_date: datetime | None, run_after:
datetime = timezone.utcnow()
+ ) -> str:
Review Comment:
Same, don’t change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
