pierrejeambrun commented on code in PR #46348:
URL: https://github.com/apache/airflow/pull/46348#discussion_r1968048029
##########
airflow/ui/src/components/ActionAccordion/ActionAccordion.tsx:
##########
@@ -29,13 +29,14 @@ import { columns } from "./columns";
type Props = {
readonly affectedTasks?: TaskInstanceCollectionResponse;
readonly note: DAGRunResponse["note"];
- readonly setNote: (value: string) => void;
+ readonly setNote: ((value: string) => void) | undefined;
};
// Table is in memory, pagination and sorting are disabled.
// TODO: Make a front-end only unconnected table component with client side
ordering and pagination
const ActionAccordion = ({ affectedTasks, note, setNote }: Props) => {
const showTaskSection = affectedTasks !== undefined;
+ const showNoteSection = note !== null;
Review Comment:
What was the motivation for this ?
It looks like the Note section is now missing when we are Clearing or
MarkingAs in case we want to add a new note. We can basically only 'edit' an
existing note but not add one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
