aritra24 commented on code in PR #46348:
URL: https://github.com/apache/airflow/pull/46348#discussion_r1969466350
##########
airflow/ui/src/components/ActionAccordion/ActionAccordion.tsx:
##########
@@ -29,13 +29,14 @@ import { columns } from "./columns";
type Props = {
readonly affectedTasks?: TaskInstanceCollectionResponse;
readonly note: DAGRunResponse["note"];
- readonly setNote: (value: string) => void;
+ readonly setNote: ((value: string) => void) | undefined;
};
// Table is in memory, pagination and sorting are disabled.
// TODO: Make a front-end only unconnected table component with client side
ordering and pagination
const ActionAccordion = ({ affectedTasks, note, setNote }: Props) => {
const showTaskSection = affectedTasks !== undefined;
+ const showNoteSection = note !== null;
Review Comment:
Yup, I have the code pushed with the revert, but I'm not at my laptop right
now. I'll raise a pr once I get home in a couple of hours?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
