vincbeck commented on code in PR #47432:
URL: https://github.com/apache/airflow/pull/47432#discussion_r1993591224
##########
airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -66,6 +67,12 @@
T = TypeVar("T", bound=BaseUser)
+class BaseAuthManagerConstants(enum.Enum):
+ """Constants for BaseAuthManager."""
+
+ COOKIE_JWT_TOKEN = "_token"
+
+
Review Comment:
```suggestion
COOKIE_NAME_JWT_TOKEN = "_token"
```
##########
airflow/api_fastapi/auth/managers/simple/routes/login.py:
##########
@@ -63,7 +64,14 @@ def create_token_all_admins() -> RedirectResponse:
role="ADMIN",
)
url = urljoin(conf.get("api", "base_url"),
f"?token={get_auth_manager().get_jwt_token(user)}")
Review Comment:
```suggestion
```
##########
airflow/api_fastapi/auth/managers/simple/routes/login.py:
##########
@@ -63,7 +64,14 @@ def create_token_all_admins() -> RedirectResponse:
role="ADMIN",
)
url = urljoin(conf.get("api", "base_url"),
f"?token={get_auth_manager().get_jwt_token(user)}")
- return RedirectResponse(url=url)
+ response = RedirectResponse(url=url)
Review Comment:
```suggestion
response = RedirectResponse(url=conf.get("api", "base_url"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
