gopidesupavan commented on code in PR #47432:
URL: https://github.com/apache/airflow/pull/47432#discussion_r1994000046
##########
providers/fab/src/airflow/providers/fab/www/views.py:
##########
@@ -70,7 +72,9 @@
def index(self):
if g.user is not None and g.user.is_authenticated:
token = get_auth_manager().get_jwt_token(g.user)
- return redirect(urljoin(conf.get("api", "base_url"),
f"?token={token}"), code=302)
+ response = make_response(redirect(f"{conf.get('api',
'base_url')}", code=302))
+ response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=True,
samesite="Lax")
Review Comment:
Okay will remove that, even i am not strong on that what it does, but i when
i tested it worked for both lax and strict and default browser option is lax.
so will remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
