pierrejeambrun commented on code in PR #47432:
URL: https://github.com/apache/airflow/pull/47432#discussion_r1995503581
##########
providers/fab/src/airflow/providers/fab/www/views.py:
##########
@@ -70,7 +72,10 @@
def index(self):
if g.user is not None and g.user.is_authenticated:
token = get_auth_manager().get_jwt_token(g.user)
- return redirect(urljoin(conf.get("api", "base_url"),
f"?token={token}"), code=302)
+ response = make_response(redirect(f"{conf.get('api',
'base_url')}", code=302))
+ response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=True)
Review Comment:
Unfortunately I don't think we can do much here regarding the security
warning raised, because we want our JS front-end code to manipulate this...
##########
providers/fab/src/airflow/providers/fab/www/views.py:
##########
@@ -70,7 +72,10 @@
def index(self):
if g.user is not None and g.user.is_authenticated:
token = get_auth_manager().get_jwt_token(g.user)
- return redirect(urljoin(conf.get("api", "base_url"),
f"?token={token}"), code=302)
+ response = make_response(redirect(f"{conf.get('api',
'base_url')}", code=302))
+ response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=True)
Review Comment:
Unfortunately I don't think we can do much here regarding the security
warning raised. We can't use httpOnly because we want our JS front-end code to
manipulate this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
