tirkarthi opened a new pull request, #47795:
URL: https://github.com/apache/airflow/pull/47795

   The implementation adds an `id` per log line span element. The line number 
is prepended to the log line. Then on clicking the line number the page scrolls 
to the line. Then the URL with line number in hash can be copied and shared. On 
opening the URL the hash value line number is detected and scrolls to the line 
number. When the hash is present then log groups are expanded on load since the 
page scrolls to the id and the id can be part of content inside the log group.
   
   Notes to reviewer and self
   
   1. On clicking a line inside the log group I am seeing the group getting 
duplicated. I have seen this in in progress task logs with log group too 
sometime back I guess. On page refresh the rendering is correct with no 
duplicates. This could be unrelated to this PR and perhaps a separate issue.
   2. Perhaps on clicking the line number don't scroll and just copy the url 
content to be shared.
   
   Demo video
   
   
https://github.com/user-attachments/assets/364f137d-8967-475f-b57f-7df36a199f6d
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to