bbovenzi commented on code in PR #47795:
URL: https://github.com/apache/airflow/pull/47795#discussion_r1996978448
##########
airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx:
##########
@@ -30,24 +32,47 @@ type Props = {
readonly wrap: boolean;
};
-export const TaskLogContent = ({ error, isLoading, logError, parsedLogs, wrap
}: Props) => (
- <Box>
- <ErrorAlert error={error ?? logError} />
- <ProgressBar size="xs" visibility={isLoading ? "visible" : "hidden"} />
- <Code
- css={{
- "& *::selection": {
- bg: "blue.subtle",
- },
- }}
- overflow="auto"
- py={3}
- textWrap={wrap ? "pre" : "nowrap"}
- width="100%"
- >
- <VStack alignItems="flex-start" gap={0}>
- {parsedLogs}
- </VStack>
- </Code>
- </Box>
-);
+export const TaskLogContent = ({ error, isLoading, logError, parsedLogs, wrap
}: Props) => {
+ const { colorMode } = useColorMode();
+ const [bgLight, bgDark] = useToken("colors", ["blue.400", "blue.700"]);
Review Comment:
Why a custom color instead of `blue.emphasized`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
