tyrellcurry commented on code in PR #47821:
URL: https://github.com/apache/airflow/pull/47821#discussion_r1997664541
##########
airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -89,7 +101,12 @@ export const DetailsLayout = ({ children, error, isLoading,
tabs }: Props) => {
<Panel defaultSize={dagView === "graph" ? 30 : 80} minSize={20}>
<Box display="flex" flexDirection="column" h="100%">
{children}
- <ErrorAlert error={error} />
+ <VStack ml={2} my={2}>
+ <ErrorAlert error={error} />
+ {warning?.dag_warnings.map((warningItem) => (
+ <WarningAlert key={warningItem.dag_id} warning={warningItem}
/>
Review Comment:
Ah right, thanks for catching that. I saw our linting rules does not allow
us to use index anywhere in the key, so how do you feel about timestamp? eg.
`asset_name_uri-2025-03-16T16:32:41.965952Z`
Since it's down to the microsecond, we should be okay for uniqueness.
I'll do a push with this change to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
