tyrellcurry commented on PR #47821: URL: https://github.com/apache/airflow/pull/47821#issuecomment-2735093529
> > Also, just realized that those warnings are not part of the 'scrollable' area. So if we get too many of them I think it will just push out of the screen the rest of the details pane without having the ability to scroll down. > > Let's match how our list of Dag Import Errors works: <img alt="Screenshot 2025-03-18 at 12 55 03 PM" width="225" src="https://private-user-images.githubusercontent.com/4600967/424096060-bacdefca-3839-4f2e-aaab-b136d9fa1df7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDIzMTg2NjYsIm5iZiI6MTc0MjMxODM2NiwicGF0aCI6Ii80NjAwOTY3LzQyNDA5NjA2MC1iYWNkZWZjYS0zODM5LTRmMmUtYWFhYi1iMTM2ZDlmYTFkZjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDMxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAzMThUMTcxOTI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWJlZmE4ZWExZGY2ZTI1YzVhZGQ5YWRhZDlhMzk4ZDVkZTYxMjdiZDA0OThhOGU1Y2Q1ODg0ZjE4MmJmZTA1YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.dmWY1-yuoXagVvuACjfB-IurAExpxRKyD50T0SM0BgY";> > > Instead of a banner, we show warning or error icons next to the dag_display_name. And clicking on it should open a modal with more info. Especially with warnings, sometimes a user doesnt want it to disrupt the whole details panel @bbovenzi I'm happy to rework this to that new notification style. Where would we want it? Are you saying have the icon next to the name in list view? Or have the icon next to the name once you've opened the DAG in the DAG Details view? If you don't mind sending me a quick screenshot for placement, that would be super helpful! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/4600967/424096060-bacdefca-3839-4f2e-aaab-b136d9fa1df7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDIzMTg2NjYsIm5iZiI6MTc0MjMxODM2NiwicGF0aCI6Ii80NjAwOTY3LzQyNDA5NjA2MC1iYWNkZWZjYS0zODM5LTRmMmUtYWFhYi1iMTM2ZDlmYTFkZjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDMxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAzMThUMTcxOTI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWJlZmE4ZWExZGY2ZTI1YzVhZGQ5YWRhZDlhMzk4ZDVkZTYxMjdiZDA0OThhOGU1Y2Q1ODg0ZjE4MmJmZTA1YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.dmWY1-yuoXagVvuACjfB-IurAExpxRKyD50T0SM0BgY"](https://private-user-images.githubusercontent.com/4600967/424096060-bacdefca-3839-4f2e-aaab-b136d9fa1df7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDIzMTg2NjYsIm5iZiI6MTc0MjMxODM2NiwicGF0aCI6Ii80NjAwOTY3LzQyNDA5NjA2MC1iYWNkZWZjYS0zODM5LTRmMmUtYWFhYi1iMTM2ZDlmYTFkZjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDMxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAzMThUMTcxOTI2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWJlZmE4ZWExZGY2ZTI1YzVhZGQ5YWRhZDlhMzk4ZDVkZTYxMjdiZDA0OThhOGU1Y2Q1ODg0ZjE4MmJmZTA1YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.dmWY1-yuoXagVvuACjfB-IurAExpxRKyD50T0SM0BgY"){kind=link}