gopidesupavan commented on code in PR #48118:
URL: https://github.com/apache/airflow/pull/48118#discussion_r2010874695
##########
.github/workflows/ci-image-checks.yml:
##########
@@ -377,16 +377,13 @@ jobs:
rm /tmp/awscliv2.zip
sudo /tmp/aws/install --update
rm -rf /tmp/aws/
- if: inputs.branch == 'main'
- name: Configure AWS credentials
uses:
aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a
# v4.0.1
- if: inputs.branch == 'main'
with:
aws-access-key-id: ${{ secrets.DOCS_AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.DOCS_AWS_SECRET_ACCESS_KEY }}
aws-region: eu-central-1
- name: "Upload documentation to AWS S3"
- if: inputs.branch == 'main'
Review Comment:
Actually it wont trigger we have and condition at Job level here
https://github.com/apache/airflow/pull/48118/files#diff-abe78e8f48c54c3cea977de0f6ad47870b0cf21522527a4b67a3aaa401c54a95R327.
it needs canary and branch name main. so the ones removed are extra ifs. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
