PNL0 commented on code in PR #47557:
URL: https://github.com/apache/airflow/pull/47557#discussion_r2014969111
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -246,6 +247,23 @@ def patch_dag(
data = patch_body.model_dump(include=fields_to_update, by_alias=True)
+ is_paused = data.get("is_paused")
+
+ active_dag_runs = session.scalars(
+ select(DagRun).filter(
+ DagRun.dag_id == dag_id, DagRun.state.in_([DagRunState.RUNNING,
DagRunState.QUEUED])
+ )
+ ).all()
+
+ for dag_run in active_dag_runs:
+ if is_paused:
+ dag_run.set_state(DagRunState.QUEUED)
Review Comment:
> What do you think about failing all running dagruns once the dag is
paused? Skipping those that are not running. Just the way we handle dagrun
timeout
I think it's a good idea.
I tried to implement what you described in my updated commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
