guan404ming opened a new pull request, #48875:
URL: https://github.com/apache/airflow/pull/48875

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   
   ## Why
   
   This PR addresses the ongoing discussion regarding the introduction of a 
generic `get_df` function, which would abstract the retrieval of dataframes 
from various sources, supporting both pandas and polars. The goal is to provide 
a more user-friendly and consistent API.
   
   As discussed, there are arguments against a direct implementation, primarily 
concerning:
   
   * **Complexity and Maintenance:** Concerns that a single implementation 
could become overly complex, especially considering the syntactic differences 
between pandas and polars querying APIs. (@Taragolis, @bfeif)
   * **Potential Breaking Changes:** Concerns about future breaking changes if 
existing methods were removed. (@bfeif)
   * **Current Pandas Issues:** Existing issues with the pandas implementation 
should be addressed first. (@Taragolis)
   * **Over-engineering:** The feeling that this change is an over-engineering. 
(@bfeif)
   
   However, there is also support for a more abstract approach:
   
   * **Abstraction and Simplification:** A generic `get_df` could simplify user 
interaction and provide a consistent interface. (@eladkal)
   * **Gradual Transition:** Deprecation warnings can be used to facilitate a 
smooth transition, allowing users time to adapt. (@eladkal)
   
   ## How
   
   This PR implements `get_df` while maintaining a flexible approach to address 
the community's concerns.
   
   * `get_df` is introduced as a new, generic function that accepts a parameter 
specifying the desired dataframe type (pandas or polars).
   * This implementation introduces the `get_polars_df` and `get_pandas_df` 
methods that are used within the `get_df` method. This allows the new generic 
method to function, while allowing the option to expose or deprecate the 
underlying methods in the future.
   * This approach allows for a gradual transition and addresses the concerns 
about immediate breaking changes.
   * The implementation is designed to be easily modified based on community 
feedback.
   
   This PR aims to provide a flexible solution that can be adapted based on 
community consensus. The implementation can be refined or reverted as needed, 
ensuring that the changes align with the project's long-term goals.
   
   ## Note
   
   This PR is considered a starting point for discussion and may require 
further triage by the community. I plan to implement the corresponding changes 
within the Google provider after this PR is reviewed and a consensus is 
reached, as it is dependent on the outcome of this discussion. This separation 
allows for focused review and iteration on the core functionality before 
extending it to specific providers.
   
   Also, encourage interested community members to participate in the 
discussion and provide feedback on this PR. I think achieving consensus within 
the community is really crucial!
   
   
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to