eladkal commented on code in PR #48875:
URL: https://github.com/apache/airflow/pull/48875#discussion_r2039242620


##########
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:
##########
@@ -426,6 +449,37 @@ def get_pandas_df_by_chunks(
         with closing(self.get_conn()) as conn:
             yield from psql.read_sql(sql, con=conn, params=parameters, 
chunksize=chunksize, **kwargs)
 
+    def get_polars_df(

Review Comment:
   I think we may want to have `get_polars_df` as private function so that 
users will use the public api of `get_df`
   we need also to do that for `get_pandas_df` -> `_ get_pandas_df` but still 
keep get_pandas_df with deprecation warning 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to