eladkal commented on code in PR #49467: URL: https://github.com/apache/airflow/pull/49467#discussion_r2052100157
########## providers/snowflake/docs/changelog.rst: ########## @@ -27,6 +27,17 @@ Changelog --------- +7.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. warning:: + The following breaking changes were introduced: + * ``private_key_content`` in Snowflake connection should now be base64 encoded. Review Comment: I am not confident this is a breaking change. This feels more like a bug fix. Correct me if I am wrong but starting the commit that "broke" it, this never worked as intended? Is there any production environment out there that the current code works for them thus changing it to fix the bug will cause a breaking change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
