rawwar commented on code in PR #49467: URL: https://github.com/apache/airflow/pull/49467#discussion_r2052552037
########## providers/snowflake/docs/changelog.rst: ########## @@ -27,6 +27,17 @@ Changelog --------- +7.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. warning:: + The following breaking changes were introduced: + * ``private_key_content`` in Snowflake connection should now be base64 encoded. Review Comment: You are correct that an earlier commit which marked the connection field as private broke it. I don't think it worked after that. But, customer's still need to update the keys to be base64 encoded. If you don't think this is a breaking change, I'll bump the minor version ########## providers/snowflake/docs/changelog.rst: ########## @@ -27,6 +27,17 @@ Changelog --------- +7.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. warning:: + The following breaking changes were introduced: + * ``private_key_content`` in Snowflake connection should now be base64 encoded. Review Comment: You are correct that an earlier commit which marked the connection field as private broke it. I don't think it worked after that. But, users still need to update the keys to be base64 encoded. If you don't think this is a breaking change, I'll bump the minor version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
