gopidesupavan commented on code in PR #49818:
URL: https://github.com/apache/airflow/pull/49818#discussion_r2061308608


##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -669,7 +681,14 @@ def get_task_instance_states(
     if task_group_id:
         group_tasks = _get_group_tasks(dag_id, task_group_id, session, 
logical_dates, run_ids)
 
-        [run_id_task_state_map[task.run_id].update({task.task_id: task.state}) 
for task in group_tasks]
+        if map_index is None:

Review Comment:
   I have two questions here.
   
   1. Until now we were just returning the the response for the get_task_states 
with task ids like this i.e
   ```
   {
     "manual__2025-04-26T13:12:28.740030+00:0": {
       "start": "success",
       "example_group.example_python_op": "success",
       "example_group.add_one": "success"
     }
   }
   ```
   If we have dynamic tasks exists i am thinking to include those tasks like 
this?
   ```
   {
     "manual__2025-04-26T13:12:28.740030+00:0": {
       "start": "success",
       "example_group.example_python_op": "success",
       "example_group.add_one_0": "success",
       "example_group.add_one_1": "success",
       "example_group.add_one_2": "success"
     }
   }
   ```
   
   2. I think its a bug i feel at present , we return all the tasks states in 
response even when user provides input task_group_id. should i update this to 
return only those tasks under task_group. 
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to