gopidesupavan commented on code in PR #49818:
URL: https://github.com/apache/airflow/pull/49818#discussion_r2063075925


##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -664,12 +673,24 @@ def get_task_instance_states(
 
     results = session.scalars(query).all()
 
-    [run_id_task_state_map[task.run_id].update({task.task_id: task.state}) for 
task in results]
-
     if task_group_id:
         group_tasks = _get_group_tasks(dag_id, task_group_id, session, 
logical_dates, run_ids)
 
-        [run_id_task_state_map[task.run_id].update({task.task_id: task.state}) 
for task in group_tasks]
+        if task_ids:
+            results = results + group_tasks
+        else:
+            results = group_tasks

Review Comment:
   Yeah updated , but if check is on task_ids, we have to return only 
task_group_id results when task_group_id provides otherwise we will return all 
results + task_group. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to