ayush3singh commented on code in PR #50376:
URL: https://github.com/apache/airflow/pull/50376#discussion_r2083271436
##########
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -444,6 +444,7 @@ class TaskInstanceInfo(InfoJsonEncodable):
includes = ["duration", "try_number", "pool", "queued_dttm", "log_url"]
casts = {
+ "log_url": lambda ti: ti.log_url if getattr(ti, "log_url", -1) != -1
else None,
Review Comment:
Hi @amoghrajesh
without this log_url gets included in the final object `TaskInstanceInfo`
and although it is set to none we have to adjust the utils testcases to add
`log_url` in assert statements as shown below
`
assert dict(TaskInstanceInfo(runtime_ti)) == {
"log_url": None,
`
and since log_url is now expected but its not available in Airflow 3.0.0 I
guess, so below compatibility test fails:
[provider distributions tests / Compat
3.0.0:P3.9](https://github.com/apache/airflow/actions/runs/14947763348/job/41993407704#logs)
if we make this change then the Test passes as it will keep a place holder
if not available.
I'm fairly new in contribution to airflow repo, please let me know if I'm
missing out on something.
Thanks for review comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
