ayush3singh commented on code in PR #50376:
URL: https://github.com/apache/airflow/pull/50376#discussion_r2084054293
##########
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -444,6 +444,7 @@ class TaskInstanceInfo(InfoJsonEncodable):
includes = ["duration", "try_number", "pool", "queued_dttm", "log_url"]
casts = {
+ "log_url": lambda ti: getattr(ti, "log_url", None),
Review Comment:
Hi @kacpermuda
without this , the below compatibility test fails:
provider distributions tests / Compat 3.0.0:P3.9
if we make this change then the Test succeeds as it will keep a place holder
if not available in object ( in case of Airflow)
Keeping in `includes` list will add attribute only if original json hasvthe
key, but in Airflow 3.0 its not present
Thanks for review comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
