guan404ming commented on code in PR #50746:
URL: https://github.com/apache/airflow/pull/50746#discussion_r2095025701
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx:
##########
@@ -39,14 +45,16 @@ describe("Task log grouping", () => {
render(
<AppWrapper
initialEntries={["/dags/log_grouping/runs/manual__2025-02-18T12:19/tasks/generate"]}
/>,
);
+ await waitFor(() =>
expect(screen.queryByTestId("virtualized-list")).toBeInTheDocument());
+ await waitFor(() =>
expect(screen.queryByTestId("virtualized-item-0")).toBeInTheDocument());
+ fireEvent.scroll(screen.getByTestId("virtualized-list"), { target: {
scrollTop: 4050 } });
Review Comment:
Resolved, it would use the offsetHeight as item height and turns out to be
120 = 20 (height) * 6 (item). Thus, using ITEM_HEIGHT * 6 would be more
reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
