jscheffl commented on code in PR #49859: URL: https://github.com/apache/airflow/pull/49859#discussion_r2096387955
########## providers/edge3/docs/architecture.rst: ########## @@ -0,0 +1,189 @@ + .. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +Edge Provider Architecture +========================== + +Airflow consist of several components which are connected like in the following diagram. The Edge Worker which is +deployed outside of the central Airflow cluster is connected via HTTP(s) to the API server of the Airflow cluster: + +.. graphviz:: Review Comment: Mhm, I don't know if the new proposed images are actually "nicer" - I feel like the older ones are good as well. Do we need to change the layout engine for the new images or could we also use GraphViz which is used behind PUML as well? Then we could take-over the existing images and just use Python to attach to enums/interfaces and have a single source but generate the same results. If mixed both "img" and "image" folders are used, I think it would be okay to normalize across repo. Might be good to have oe "normalization" PR and then adding the pre-commit. Would it be meaningful to have a kinf of convention that the python files to generate an image would also resive in "img" folder? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
