uranusjr commented on code in PR #50677:
URL: https://github.com/apache/airflow/pull/50677#discussion_r2098736749
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -97,11 +98,9 @@ def add_deadline(cls, deadline: Deadline, session: Session =
NEW_SESSION):
session.add(deadline)
-class DeadlineReference(Enum):
+class DeadlineReference(LoggingMixin, Enum):
Review Comment:
This class is now awfully complex as an enum, and also does what normal
enums don’t generally do (contain an arbitrary value via `FIXED_DATETIME`).
Maybe we should split this into two classes like this
```python
class DefinedDeadline(Enum):
DAGRUN_LOGICAL_DATE = ...
DAGRUN_QUEUED_AT = ...
def evaluate(self, **kwargs):
...
@dataclass
class FixedDeadline:
at: datetime
def evaluate(self, **kwargs):
...
class DeadlineReference:
DAGRUN_LOGICAL_DATE = DefinedDeadline.DAGRUN_LOGICAL_DATE
DAGRUN_QUEUED_AT = DefinedDeadline.DAGRUN_QUEUED_AT
FIXED_DATETIME = FixedDeadline
```
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -97,11 +98,9 @@ def add_deadline(cls, deadline: Deadline, session: Session =
NEW_SESSION):
session.add(deadline)
-class DeadlineReference(Enum):
+class DeadlineReference(LoggingMixin, Enum):
Review Comment:
This class is now awfully complex as an enum, and also does what normal
enums don’t generally do (contain an arbitrary value via `FIXED_DATETIME`).
Maybe we should split this into two classes like this
```python
class DefinedDeadline(Enum):
DAGRUN_LOGICAL_DATE = ...
DAGRUN_QUEUED_AT = ...
def evaluate(self, **kwargs):
...
@dataclass
class FixedDeadline:
at: datetime
def evaluate(self, **kwargs):
...
class DeadlineReference:
DAGRUN_LOGICAL_DATE = DefinedDeadline.DAGRUN_LOGICAL_DATE
DAGRUN_QUEUED_AT = DefinedDeadline.DAGRUN_QUEUED_AT
FIXED_DATETIME = FixedDeadline
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
