eladkal commented on PR #50449:
URL: https://github.com/apache/airflow/pull/50449#issuecomment-2896785688
@potiuk I am missing something here
I see
```
==================================== ERRORS
====================================
_ ERROR collecting
providers/amazon/tests/unit/amazon/aws/auth_manager/routes/test_login.py _
ImportError while importing test module
'/opt/airflow/providers/amazon/tests/unit/amazon/aws/auth_manager/routes/test_login.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
providers/amazon/tests/unit/amazon/aws/auth_manager/routes/test_login.py:29:
in <module>
from onelogin.saml2.idp_metadata_parser import
OneLogin_Saml2_IdPMetadataParser
E ModuleNotFoundError: No module named 'onelogin'
------ generated xml file: /files/test_result-providers_amazon-sqlite.xml
------
=========================== short test summary info
============================
ERROR
providers/amazon/tests/unit/amazon/aws/auth_manager/routes/test_login.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection
!!!!!!!!!!!!!!!!!!!!
=================== 1 skipped, 1 warning, 1 error in 33.28s
====================
```
This is due to
https://github.com/apache/airflow/blob/2442b215db2e800b72af06bba80b327fce5a41d1/providers/amazon/tests/unit/amazon/aws/auth_manager/routes/test_login.py#L29
but this import should be available when the
`apache-airflow-providers-amazon[python3-saml]` is installed in the CI. So I
guess I am missing something to make this extra installed in the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
