o-nikolas commented on code in PR #51326:
URL: https://github.com/apache/airflow/pull/51326#discussion_r2122125726
##########
task-sdk/src/airflow/sdk/definitions/deadline.py:
##########
@@ -58,9 +126,9 @@ class DeadlineReference:
from airflow.models.deadline import ReferenceModels
Review Comment:
Curious if this coupling is going to give us any grief in the future. Means
that core airflow and the sdk need to be aware of each other for Deadlines.
##########
task-sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -50,13 +50,13 @@
ParamValidationError,
TaskNotFound,
)
-from airflow.models.deadline import DeadlineAlert
Review Comment:
Nice, I didn't like the coupling of models to sdk here. Felt like a leak of
internal airflow into the task sdk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
