o-nikolas commented on code in PR #51326:
URL: https://github.com/apache/airflow/pull/51326#discussion_r2124479716
##########
task-sdk/src/airflow/sdk/definitions/deadline.py:
##########
@@ -58,9 +126,9 @@ class DeadlineReference:
from airflow.models.deadline import ReferenceModels
Review Comment:
> Hmm, if we move it out of core airflow, where could we evaluate the
deadline references? Maybe dag-processor and have the scheduler use the
evaluated timestamp to check if a deadline has passed? 🤔
I'm not talking about functional changes at that level. I'm just pointing
out that the SDK is now coupled to the core code base, via these imports. Which
means if changes happen to deadline stuff in core code the sdk needs to be
updated at the same time, and both code bases need to be deployed on the host
at the same time, etc. I'm just curious if the SDK folks (@ashb, @amoghrajesh,
etc) had a plan or recipe for this.
TP had some interesting suggestions. I think Dennis is already doing the
second one (imported in functions) as much as possible already which is good,
but there is still a coupling nonetheless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
