bbovenzi commented on code in PR #51541:
URL: https://github.com/apache/airflow/pull/51541#discussion_r2136268035
##########
airflow-core/src/airflow/ui/src/components/DagActions/inlineMessage.tsx:
##########
@@ -22,11 +22,11 @@ import type { TFunction } from "i18next";
export const getInlineMessage = (isPendingDryRun: boolean, totalEntries:
number, translate: TFunction) =>
isPendingDryRun ? (
<Skeleton height="20px" width="100px" />
- ) : totalEntries > 1 ? (
+ ) : totalEntries === 1 ? (
<Text color="fg.success" fontSize="sm">
{translate("backfill.affectedOne")}
</Text>
- ) : totalEntries > 0 ? (
+ ) : totalEntries > 1 ? (
<Text color="fg.success" fontSize="sm">
{translate("backfill.affectedMultiple", { count: totalEntries })}
Review Comment:
We can simplify this even more.
change the keys to `backfill.affected_{one || other}`
then call translate with
`{translate("backfill.affected", { count: totalEntries })}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
