bbovenzi commented on code in PR #51541:
URL: https://github.com/apache/airflow/pull/51541#discussion_r2138681969
##########
airflow-core/src/airflow/ui/src/components/DagActions/inlineMessage.tsx:
##########
@@ -22,11 +22,11 @@ import type { TFunction } from "i18next";
export const getInlineMessage = (isPendingDryRun: boolean, totalEntries:
number, translate: TFunction) =>
isPendingDryRun ? (
<Skeleton height="20px" width="100px" />
- ) : totalEntries > 1 ? (
+ ) : totalEntries === 1 ? (
<Text color="fg.success" fontSize="sm">
{translate("backfill.affectedOne")}
</Text>
- ) : totalEntries > 0 ? (
+ ) : totalEntries > 1 ? (
<Text color="fg.success" fontSize="sm">
{translate("backfill.affectedMultiple", { count: totalEntries })}
Review Comment:
Oh sorry I meant that we should use the plural support that's already in
`react-i18next`. Look at `_one` and `_other` in other translation keys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
