ferruzzi commented on code in PR #51638:
URL: https://github.com/apache/airflow/pull/51638#discussion_r2141995172
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -220,9 +220,12 @@ class DagRunQueuedAtDeadline(BaseDeadlineReference):
required_kwargs = {"dag_id"}
- def _evaluate_with(self, **kwargs: Any) -> datetime:
+ @provide_session
+ def _evaluate_with(self, session=NEW_SESSION, **kwargs: Any) ->
datetime:
from airflow.models import DagRun
+ session.flush()
Review Comment:
The issue I ran into with that was if I provide a session to
`_set_dagrun_queued_deadline`, even if I don't use it for anything, just add it
to the signature, it breaks three of the existing tests and I'm not sure why.
Do you perhaps see the cause there? Either way, it's 1AM and I need sleep,
I'll poke it more "in the morning".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
