codenamelxl commented on code in PR #51256:
URL: https://github.com/apache/airflow/pull/51256#discussion_r2143055623
##########
providers/git/src/airflow/providers/git/hooks/git.py:
##########
@@ -89,7 +90,7 @@ def _process_git_auth_url(self):
if not isinstance(self.repo_url, str):
return
if self.auth_token and self.repo_url.startswith("https://";):
- self.repo_url = self.repo_url.replace("https://";,
f"https://{self.auth_token}@";)
+ self.repo_url = self.repo_url.replace("https://";,
f"https://{self.user_name}:{self.auth_token}@";)
Review Comment:
Yes, I've tested `"whatever"` user work for github as well.
For Gitlab,
https://docs.gitlab.com/user/profile/personal_access_tokens/#clone-repository-using-personal-access-token
it's mentioned that the `user` can be any string and cannot be empty.
I don't have any Bitbucket to test. But its doc:
https://confluence.atlassian.com/bitbucketserver/http-access-tokens-939515499.html#:~:text=Or%20using%20Basic%20Auth%3A
seems to suggest that a `user` is required as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
